Repository navigation
Add support for logr - #37
Merged
Merged
Conversation
Convert to structured log support
Change-Id: I92207e2ca9bbd88a8780912a3aef297685c917f6
Change-Id: I3117562d1eecee175ac06443a79b717296f6149e
Change-Id: I813d542005959293327057ff3ddf81da4e454581
Change-Id: Ia25673d014bcfc1f23aee7cb4856e1e24cba02fb
Change-Id: I4e2c5a7ff5b2526bafac0cd17836b3377a91339d
k8s-ci-robot
added
cncf-cla: yes
Member
Author
|
/assign @thockin |
Member
Author
|
/assign @vincepri @thockin @DirectXMan12 |
Member
Author
|
/hold (for discussion) |
k8s-ci-robot
added
the
do-not-merge/hold
Member
|
cc @munnerz |
thockin
reviewed
Jan 25, 2019
| "k8s.io/klog" | ||
| ) | ||
|
|
||
| // New returns a logr.Logger which is implemented by glog. |
| return new | ||
| } | ||
|
|
||
| // WithName returns a new logr.Logger with the specified name appended. glogr |
Change-Id: Ie02835fa7e1fb01ccfe64deb30a414cabae70067
dims
force-pushed
the
add-support-for-logr
branch
from
January 25, 2019 22:10
6808784 to
2ecd970
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
Do we need the hold? |
Member
Author
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We have libraries like k8s.io/utils that need logging, we should have a way to use the
logrin these scenarios. For example see kubernetes/utils#70Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: